Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infrastructure files #21

Merged
merged 8 commits into from
Sep 4, 2020
Merged

Add infrastructure files #21

merged 8 commits into from
Sep 4, 2020

Conversation

mrakitin
Copy link
Member

@mrakitin mrakitin commented Sep 3, 2020

Summary:

LICENSE Outdated
@@ -0,0 +1,29 @@
BSD 3-Clause License

Copyright (c) 2020, Brookhaven Science Associates, Brookhaven National Laboratory

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not need to name BSA and should just name BNL, like so:

Copyright (c) 2020, Brookhaven National Laboratory

See @stuartcampbell's comment on this issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for pointing it out. I actually copied it from SRX, I'll correct it there as well.

@mrakitin mrakitin marked this pull request as ready for review September 3, 2020 22:14
@mrakitin
Copy link
Member Author

mrakitin commented Sep 3, 2020

This is done for now. I tested the code correctly handles the versions of the package based on the tag/number of commits from tag.

CI can be enabled in a separate PR.

@mrakitin
Copy link
Member Author

mrakitin commented Sep 3, 2020

Please note this commit: 5466d2e. It's only needed when we render README.md files. We don't need it for plain text or README.rst files (which are default in https://github.com/NSLS-II/scientific-python-cookiecutter).

xref: NSLS-II/scientific-python-cookiecutter#25.

setup.py Outdated Show resolved Hide resolved
Copy link

@MikeHart85 MikeHart85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Josh's comment. Everything else looks good to go.

@mrakitin mrakitin requested a review from jklynch September 4, 2020 15:46
@jklynch jklynch merged commit 5ba89a4 into master Sep 4, 2020
@jklynch jklynch deleted the fix-packaging branch September 4, 2020 15:47
@mrakitin
Copy link
Member Author

mrakitin commented Sep 4, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants